Earth And Fire Elementals Spells

Intro:

The elementals summoned by Earth Elemental Totem and Fire Elemental totems should cast spells, since i can’t find a patch anywhere that fix those totems i decided to make it myself.

I made this most blizzlike possible, everything comes from a source and confirmed by friends who plays retail.

In this post i will explain every change made by this patch and why i did it. Suggestions for better implementation are welcomed!

Let’s start with main sources of information referenced on this post:

DPS Calculator projects:

Rawr RELEASE v2.3.22 - FireElemental.cs - (WoW 3.3.5)

Simulationcraft simc-335-1-win32 - sc_shaman.cpp - (WoW 3.3.5)

Simulationcraft Trunk - sc_shaman.cpp - (Cata)

WowWiki:

http://www.wowwiki.c…Elemental_Totem

http://www.wowwiki.c…Elemental_Totem

WoWHead:

http://www.wowhead.com/spell=2894 and Greater Fire Elemental - NPC - World of Warcraft

http://www.wowhead.com/spell=2062 and Greater Earth Elemental - NPC - World of Warcraft

YouTube Videos:

3:01 to 3:45 and 6:10 to 7:22

youtube.com/watch?v=Ft_Zc-I-Ws8

7:07 to 7:42 and 8:12 to 9:10

youtube.com/watch?v=hneJi1HxCPE

0:55 to 1:37

youtube.com/watch?v=gwREdIHjPJM

DBC Data:

http://dbc.it.cx/dbc/index.php?sQuery=Id%3D57984+OR+Id%3D13376+OR+Id%3D12470+OR+Id%3D32982+OR+Id%3D32186+OR+Id%3D33663+OR+Id%3D36213&rowsFrom=0&rowsTo=200&oderCell=Id&order=ASC&submit=Submit

http://www.wowpedia.org/images/3/38/Spell_fire_elemental_totem.png[B][SIZE=18px]Greater Fire Elemental:[/SIZE][/B]

Immunities: This elemental should be immune to all kinds of fire damage.

SP from owner: They gains 50% of the base fire spell damage from the owner (explained below)

Melee damage, HP and Mana: Melee damage seems to be a bit low, HP and Mana looks ok, no reason to change the current code.

Spells: They cast 3 spells:

Fire Shield: This spell deals 95 fire damage (whitout bonus) to nearby enemys in 5yd radius.

Cooldown: Is casted every 2 seconds. Confirmed in Rawr, WoWWiki and in this YTVideo in 7:10 is clearly shown.

SP Coef: From DBCData the coeficient is EffectBonusMultiplier_1 = 0.032000001519918 , the elemental recive 0.5 of the owner’s SP base, the bonus recived from the shaman SP is 0.015. Confirmed in Simc and Rawr

Because EffectBonusMultipliers does not have any implementation on TC, spell_bonus_data is used, without this, the spell is OP.

Fire Nova: This spell deals fire damage to nearby enemis in 10yd radius. 2 sec Cast time.

Cooldown: Is casted every 5 to 20 seconds. This may need more research, i can’t find enough sources of information. But from this Simc file:

// ==========================================================================

// TODO:

// - Analysis of in-game Fire Elemental Fire Nova and Fire Blast ability cooldown

// distributions would help us make a more realistic model. The current values

// of 5-20 seconds are not very well researched.

// ==========================================================================

In this YTVideo that CD distribution seems to be correct, the video shows nova casts in 3:10 → 3:15 → 3:27 → 3:44, so the cds where 5s → 12s → 17s respectively

Fire Blast: This spell deals ~1200 fire damage (without bonus) to an enemy.

Cooldown: Same than Fire Nova.

SP Coef: EffectBonusMultiplier_1 = 0.42899999022484 , same comments that applies to Fire Shield also for this.

http://www.wowpedia.org/images/6/6c/Spell_nature_earthelemental_totem.png[SIZE=18px][B]Greater Earth Elemental:[/B][/SIZE]

Immunities: This elemental should be immune to all kinds of nature damage.

Spells: Only cast 1 spell

Angered Earth: Taunts and causes additional high threat to all enemies within 15 yards.

Cooldown: When the elemental spawn instantly cast the spell, then its casted every 5 to 20 seconds. Also need more research, this YTVideo from 0:55 shows the casts, (consider those “Target Changed!” as Angered Earth casts) 0:56 → 1:00 → 1:07 → 1:30.

For both totems:

Fire and Earth elementals are linked to their totem, they are guardians NOT of the shaman but of the totem, they should move and attack enemys around 30yd of the totem, if the enemy run far from that distance they return to the totem’s position.

TODOI can’t find a way to fix this without hacks, fix for this involves a lot of changes, i think the guardian’s behavior code need be rewritten and that would be a different fix.

CODE: https://github.com/e...eeb5a2d95efdc37a9b814bc653005e71930c2092

Thats all mates, and as i said before Suggestions for better fix are welcomed! /emoticons/default_wink.png

Edit: Corrected some codestyles and submitted pull request

Fire and Earth elementals are linked to their totem, they are guardians NOT of the shaman but of the totem, they should move and attack enemys around 30yd of the totem, if the enemy run far from that distance they return to the totem’s position.

I think that can be done by rewriting parts of the guardian code to make the totem owner of the creature. Right now in guardian summon code there’s a check like “if (isTotem()) owner = ownerOfTotem”. Perhaps we need to get rid of that and add another method to get owner of the totem if applicable and make damage calculations from that.

Why has this not been in a pull-request yet?

its a nice fix. i really like it.

commit link gives a 404 error :confused: still have this patch?

This was added in https://github.com/TrinityCore/TrinityCore/commit/eeb5a2d95efdc37a9b814bc653005e71930c2092 (thanks vincent)