LootTemplate::CopyConditions() seems to only erase conditions

TrinityCore Development TrinityCore Code Discussion
1

I’m not sure I understand what’s going on in these blocks of code:

The firs block takes a ConditionList arguement and clears all the conditions. It then calls CopyConditions() for LootGroup and also clears all the conditions (as shown in the second code block).

Nowhere does it actually copy anything that I can see, it only seems to clear everything.

[CODE]void LootTemplate::CopyConditions(ConditionList conditions)

{

for (LootStoreItemList::iterator i = Entries.begin(); i != Entries.end(); ++i)

    i->conditions.clear();


for (LootGroups::iterator i = Groups.begin(); i != Groups.end(); ++i)

    i->CopyConditions(conditions);

}[/CODE]

[CODE]void LootTemplate::LootGroup::CopyConditions(ConditionList /conditions/)

{

for (LootStoreItemList::iterator i = ExplicitlyChanced.begin(); i != ExplicitlyChanced.end(); ++i)

{

    i->conditions.clear();

}

for (LootStoreItemList::iterator i = EqualChanced.begin(); i != EqualChanced.end(); ++i)

{

    i->conditions.clear();

}

}[/CODE]

2

Well, I ended up creating this override which works fine. I need to use it when loading the LootItem from the DB. This allows me to apply the original conditions that were applied when the loot was rolled.

[CODE]void LootTemplate::CopyConditions(LootItem* li) const

{

// Copies the conditions list from a template item to a LootItem

for (LootStoreItemList::const_iterator _iter = Entries.begin(); _iter != Entries.end(); ++_iter)

{

    if (_iter->itemid == li->itemid)

    {

        li->conditions = _iter->conditions;

        break;

    }


    continue;

}

}[/CODE]