new opcodes

TrinityCore Development TrinityCore Code Discussion
1

I write here because i’d like to help the development (i’m not a pro but i want to try).

Before WOD the procedure was this:

find hex

use ida to find the handler

write the handler into the core

inside the handler function we used to re-order a guid for example:

ObjectGuid guid;
guid[1] = recvData.ReadBit();
guid[0] = recvData.ReadBit();
guid[5] = recvData.ReadBit();
guid[3] = recvData.ReadBit();
guid[4] = recvData.ReadBit();
guid[2] = recvData.ReadBit();
guid[7] = recvData.ReadBit();
guid[6] = recvData.ReadBit();
recvData.ReadByteSeq(guid[4]);
recvData.ReadByteSeq(guid[6]);
recvData.ReadByteSeq(guid[3]);
recvData.ReadByteSeq(guid[1]);
recvData.ReadByteSeq(guid[2]);
recvData.ReadByteSeq(guid[7]);
recvData.ReadByteSeq(guid[0]);
recvData.ReadByteSeq(guid[5]);

now i don’t see the re-order procedure… why?

2

It’s no longer needed. Since 6.x, ‘bitshiffted’ guids are gone and new guids are all 128 bits (2x old packedreadguid())

Trinity:

packet >> guid;
packet << guid;

WowPacketParser:

packet.ReadPackedGuid128("guid");