[Patch] Gunship Battle

Custom Code and Mods Custom Code and Requests
1

Hey guys, i have a partly new and partly updated gunship_battle script for you /emoticons/default_smile.png!

Copyright and Made by:

[ul]
[li]Baeumchen [http://www.trinitycore.org/f/user/16908-maddinii2/ | []https://github.com/Baeumchen]](https://github.com/Baeumchen)[/li]
[li]Toba015 [http://www.trinitycore.org/f/user/15442-toba/ | https://github.com/Toba015 ][/li][/ul]
Including fixes:[ul]
[li]Fixed Visibility when entering Instance[/li][li]Fixed Visibility when Restarting Event [/li][li]Fixed Cannon Movement Bug[/li][li]Fixed Rocket Spell [/li][li]Fixed Server Crash[/li][li]Fixed Wave Spawning Times[/li][li]Fixed Axe Thrower[/li][li]Fixed Battle Mage[/li][li]Fixed NPC falling trough Map[/li][li]Fixed Motion of the Ship[/li][/ul]
I’m to lazy to make any vid ore Screenshot now so yeah… Here’s your Script (for latest tc):gunship_battle.patch

On my github you can get a wintergrasp fix to and in a few days a hor fix… After that i’ll work on toc (hopefully again with Toba015) /emoticons/default_smile.png So be prepared!

All script Files from this Patch can also be found on my Github.

2

Nice. Ty for sharing… Found a few bugs…

Rocket pack is out of range for enemy Ship no matter where ya stand → Also has a bug in the spell itself-> Should arc in the air, not just hover across the area you jump across.

Rocket throwers on enemy ships fire thier rockets way too fast.

Cannon damage is really low.

SQL doesn’t link all scripts correctly. item_icc_rocket_pack vs spell_icc_rocket_pack… Sindragosas Ward… Just added them manuelly.

I still get a few crashs sometimes too. If you enter cannons b4 the other ship shows, and or if you try to use the jetpack a few times to jump across…

Quick Vid…

Really nice job so far guys, thanks agian for the release.

3

Well the Trick is to NOT use the Spell Script /emoticons/default_tongue.png Since the actual Error was removed with the ship visibility error /emoticons/default_wink.png Use the Spell AS IT IS! Sorry, i should have removed it from Code :s

When you’re in the Cannon you are an un-attackable Target, that causes an error… So but this is because you are alone… If you’re in there with a raid group there ALLWAYS will be an Target /emoticons/default_tongue.png But if you wish, i’ll fix that… Have an idea already /emoticons/default_smile.png

4

Thanks for info. /emoticons/default_smile.png

5

Shouldn’t you give credits to Eilo, Hispano and Castiel?

6

Ahh I see. Thanks for the info. I’ll give it a try with a small group of people, and see how it goes. Thanks agian for sharing your work. /emoticons/default_biggrin.png

7

NiCE

8

A quick look at some of the code

-It’s pretty yucky but I’ll give you the credit for doing as you did and touching the Gunship battle.

 if ((!player->GetGroup() || !player->GetGroup()->IsLeader(player->GetGUID())) && !player->isGameMaster())
            {
                player->ADD_GOSSIP_ITEM(GOSSIP_ICON_CHAT, "I'm not the raid leader...", GOSSIP_SENDER_MAIN, GOSSIP_ACTION_INFO_DEF+2);
                player->SEND_GOSSIP_MENU(DEFAULT_GOSSIP_MESSAGE, pCreature->GetGUID());
                return true;
            }

Lmfao

That’s actually pretty funny.

9

Thanks for info, as we promise when updates are required they will be released.

10

Crash: http://paste2.org/3CY3VB3p

11

Make sure that the object t is existing. “UpdateTransportMotionInMap (t=0x0)”

12

void UpdateTransportMotionInMap(Transport* t)
{
if (!t)
return false;

Map* map = t->GetMap();

for (Map::PlayerList::const_iterator itr = map->GetPlayers().begin(); itr != map->GetPlayers().end(); ++itr)
{
    if (Player* pPlayer = itr->getSource())
    {
        UpdateData transData;
        t->BuildCreateUpdateBlockForPlayer(&transData, pPlayer);
        WorldPacket packet;
        transData.BuildPacket(&packet);
        pPlayer->SendDirectMessage(&packet);
    }
}

}

??

13

Never seen or had this crash. You added that, copy past, or did you copied whole file? One more thing, did you tried any other GB scripts before?

14

Crashed at Movement::CommonInitializer /Spline.h:189

15

Crashlog.

16

nvm, found the reason

17

other crash: http://paste2.org/5UPgtO6A

18

hey maddiini2 are you going to do trial of the champion aswell?, btw i like the gb script and hor they’re awesome thank you for them.

19

Yeah and i’m working on Blackrock Spire to /emoticons/default_smile.png

20

Same here.