WoWArmory Patch (26/11/2012)

Custom Code and Mods Custom Code and Requests
1

Hi there.

Some days ago i updated WoWArmory Patch to last rev.

It works both with CJ’s and Shadez armory, no errors, easy install.

patch -p1 < *.patch
Shadez Armory (3D Viewer Included) - Shadez/wowarmory · GitHub

Seejayz Armory (Never used this, but patch works with this armory) - https://github.com/S…fwarcraftArmory

wowarmory.2012-11-26.4dffccb.patch

2

It looks like a relatively simple mod to add neat functionality. For sanity sake would you mind linking to said Armories so the fine folks here know where to download it as well.

3

Perhaps this repository https://github.com/Seejayz/WorldofwarcraftArmory.

4

Added links to first post

Thx

5

I suggest to use git apply.

6

[CODE]git apply --check …/patches/wap.patch

error: patch failed: src/server/game/Battlegrounds/Battleground.cpp:746

error: src/server/game/Battlegrounds/Battleground.cpp: patch does not apply

error: patch failed: src/server/game/Entities/Item/Item.cpp:276

error: src/server/game/Entities/Item/Item.cpp: patch does not apply[/CODE]

I think need some changes.

7

Maybe this one will work.

It’s not tested, but I fix some errors. (Code isn’t changed.)

armory.patch

8

Updated

9

Hey Guys.

Sorry but what is the right way?

git apply --check …patch or patch -p1 < …patch ???

git apply --check …/armory.patch
fatal: corrupt patch at line 16

patch -p1 < …/armory.patch
patching file src/server/game/Achievements/AchievementMgr.cpp
patch: **** malformed patch at line 14: ca.date = time(NULL);

10

thx u very much. i’ve been searching for this error for 3 days coz my git doesnt display any errors, i’ll fix and reupload patch

11

Oh. Okay. I thank you but what is the right way for me?

the patch … or the git apply?

Every week i make core update so i wont apply the patch every week /emoticons/default_sad.png

12

just wait until i will update it, ive no idea whats wrong with my git. it’s display no errors, im like blinded trying to figure out where is the problem

13

I’ve been going over the patch code and filtered out most of the problems, but I am stuck on 2 more errors coming out of this section in the Player.cpp

/** World of Warcraft Armory **/
void Player::InitWowarmoryFeeds() {
// Clear feeds
m_wowarmory_feeds.clear();
}

void Player::CreateWowarmoryFeed(uint32 type, uint32 data, uint32 item_guid, uint32 item_quality) {
/*
1 - TYPE_ACHIEVEMENT_FEED
2 - TYPE_ITEM_FEED
3 - TYPE_BOSS_FEED
/
if (GetGUIDLow() == 0)
{
sLog->outError(LOG_FILTER_SQL, “[Wowarmory]: player is not initialized, unable to create log entry!”);
return;
}
if (type <= 0 || type > 3)
{
sLog->outError(LOG_FILTER_SQL, “[Wowarmory]: unknown feed type: %d, ignore.”, type);
return;
}
if (data == 0)
{
sLog->outError(LOG_FILTER_SQL, “[Wowarmory]: empty data (GUID: %u), ignore.”, GetGUIDLow());
return;
}
WowarmoryFeedEntry feed;
feed.guid = GetGUIDLow();
feed.type = type;
feed.data = data;
feed.difficulty = type == 3 ? GetMap()->GetDifficulty() : 0;
feed.item_guid = item_guid;
feed.item_quality = item_quality;
feed.counter = 0;
feed.date = time(NULL);
sLog->outDebug(LOG_FILTER_UNITS, “[Wowarmory]: create wowarmory feed (GUID: %u, type: %d, data: %u).”, feed.guid, feed.type, feed.data);
m_wowarmory_feeds.push_back(feed);
}
/* World of Warcraft Armory **/

Visual Studio gives me the following error messages:

function ‘void Player::InitWowarmoryFeeds(void)’ already has a body
function ‘void Player::CreateWowarmoryFeed(uint32,uint32,uint32,uint32)’ already has a body

Any idea how to fix this?

14

void Player::InitWowarmoryFeeds(void) is probably completed with initialization then I guess, same for createwowarmoryfeed

15

So, this bit has to be cut out?

16

No more news ?

said