IOC vehicles

TrinityCore Development TrinityCore Code Discussion
1

Hi all,

I’m trying to make IOC a bit more playable, So I’m trying to fix the vehicles.

Things that I have noted.

The Demolishers have the same Entry regardless of the faction.

The Glaive Throwers have different Entrys for each faction

The Catapults Have the same Entry regardless of the faction.

Here is my SQL

I AM A NEWB WITH FIXING STUFF RUN AT OWN RISK!

[CODE]

– Keep Cannon
UPDATE creature_template SET speed_walk = 0, speed_run = 0 WHERE entry = 34775; – this cannon should not be able to move

– Demolisher

delete from npc_spellclick_spells where npc_entry = 34775;
Insert into npc_spellclick_spells
(npc_entry,spell_id,quest_start,quest_start_active,quest_end,cast_flags,aura_required,aura_forbidden,user_type) values
(34775,60683,0,0,0,1,0,0,0); – I got this spell ID from the battleground demolishers from SOTA
UPDATE creature_template SET speed_walk = 1, speed_run = 1.14286 WHERE entry = 34775; – They should probably move
UPDATE creature_template SET spell1 = 67440, spell2 = 67441 WHERE entry = 34775; – According to wowhead they are casting incorrect spells

– Glaive Thrower ALLY

delete from npc_spellclick_spells where npc_entry = 34802;
Insert into npc_spellclick_spells
(npc_entry,spell_id,quest_start,quest_start_active,quest_end,cast_flags,aura_required,aura_forbidden,user_type) values
(34802,60683,0,0,0,1,0,0,0); – I got this spell ID from the battleground demolishers from SOTA
UPDATE creature_template SET spell1 = 67195, spell2 = 66456 WHERE entry = 34802; – Acording to wowhead they are casting incorrect spells

– Glaive Thrower HORDE

delete from npc_spellclick_spells where npc_entry = 35273;
Insert into npc_spellclick_spells
(npc_entry,spell_id,quest_start,quest_start_active,quest_end,cast_flags,aura_required,aura_forbidden,user_type) values
(35273,60683,0,0,0,1,0,0,0); – I got this spell ID from the battleground demolishers from SOTA
UPDATE creature_template SET spell1 = 67195, spell2 = 67034 WHERE entry = 35273; – Acording to wowhead they are casting incorrect spells

– Catapult

delete from npc_spellclick_spells where npc_entry = 34793;
Insert into npc_spellclick_spells
(npc_entry,spell_id,quest_start,quest_start_active,quest_end,cast_flags,aura_required,aura_forbidden,user_type) values
(34793,60683,0,0,0,1,0,0,0); – I got this spell ID from the battleground demolishers from SOTA
[/SQL][/CODE]

A few other things I have noted that I am going to report on the Issue tracker

The Demolisher’s Ram Spell does not work

None of the Catapults Spells work.

It is not possible to break a wall or a gate down since there is a code missing in the core.

2

Use TrinityCore code standards. Also fixed up your SQL a bit.

[CODE]-- Spells and movement for vehicles
UPDATE creature_template SET speed_walk=0, speed_run=0 WHERE entry=34944; – Keep Cannon
UPDATE creature_template SET speed_walk=1, speed_run=1.14286, spell1=67440, spell2=67441 WHERE entry=34775; – Demolisher
UPDATE creature_template SET spell1=67195 WHERE entry IN (34802, 35273); – Glaive Throwers
UPDATE creature_template SET spell2=67034 WHERE entry=35273; – Glaive Thrower horde
UPDATE creature_template SET spell2=66456 WHERE entry=34802; – Glaive Thrower alliance

– Define vehicles
DELETE FROM npc_spellclick_spells WHERE npc_entry IN (34775, 34802, 35273, 34793);
INSERT INTO npc_spellclick_spells (npc_entry, spell_id, quest_start, quest_start_active, quest_end, cast_flags, aura_required, aura_forbidden, user_type) VALUES
(34775,60683,0,0,0,1,0,0,0), – Demolisher
(34802,60683,0,0,0,1,0,0,0), – Glaive Thrower (alliance)
(35273,60683,0,0,0,1,0,0,0), – Glaive Thrower (horde)
(34793,60683,0,0,0,1,0,0,0); – Catapult[/sql]

By the way, you used a wrong id for the Keep Cannon. You used the ID of Demolisher.

[/CODE]

3

Thanks, I noticed that but then my program closed and It didn’t save the updated ID, so when I posted it was wrong.

4

Updated

I think this is all of the vehicles.

[CODE]
– Spells and movement for vehicles
UPDATE creature_template SET speed_walk=0, speed_run=0 WHERE entry IN (34944, 34929, 34935) ; – Keep Cannon, Horde gunship cannon and Alliance gunship cannon
UPDATE creature_template SET speed_walk=1, speed_run=1.14286, spell1=67440, spell2=67441 WHERE entry=34775; – Demolisher
UPDATE creature_template SET spell1=67195 WHERE entry IN (34802, 35273); – Glaive Throwers
UPDATE creature_template SET spell2=67034 WHERE entry=35273; – Glaive Thrower horde
UPDATE creature_template SET spell2=66456 WHERE entry=34802; – Glaive Thrower alliance

– Define vehicles
DELETE FROM npc_spellclick_spells WHERE npc_entry IN (34775, 34802, 35273, 34793);
INSERT INTO npc_spellclick_spells (npc_entry, spell_id, quest_start, quest_start_active, quest_end, cast_flags, aura_required, aura_forbidden, user_type) VALUES
(34775,60683,0,0,0,1,0,0,0), – Demolisher
(34802,60683,0,0,0,1,0,0,0), – Glaive Thrower (alliance)
(35273,60683,0,0,0,1,0,0,0), – Glaive Thrower (horde)
(34793,60683,0,0,0,1,0,0,0), – Catapult
(34929,60683,0,0,0,1,0,0,0), – Alliance gunship cannon
(34935,60683,0,0,0,1,0,0,0), – Horde gunship cannon
(34776,60683,0,0,0,1,0,0,0); – Siege Engine
[/sql][/CODE]

Tested A few times and It works, like I think it should work But it is probably also good that someone else should test and confirm

5

alliance glaive thrower is not “mountable” here :confused:

6

Tested with clean DB and it works Fine.

7

Check https://github.com/TrinityCore/TrinityCore/issues/1116 and add what is missing and different to your fix, pretty please.

Edit:

/* IOC */

-- Template updates for creature 34775 (Demolisher)
UPDATE creature_template SET baseattacktime=2000,unit_flags=unit_flags|16384,speed_walk=3.2 WHERE entry=35273; -- Glaive Thrower
UPDATE creature_template SET baseattacktime=2000,npcflag=npcflag|16777216,unit_flags=unit_flags|16384,speed_walk=1.2,speed_run=0.98571 WHERE entry=34775; -- Demolisher
UPDATE creature_template SET baseattacktime=2000,npcflag=npcflag|16777216,unit_flags=unit_flags|33570816,speed_run=1 WHERE entry=34935; -- Horde Gunship Cannon
UPDATE creature_template SET baseattacktime=2000,unit_flags=unit_flags|16640,unit_class=4,speed_walk=1.2,speed_run=1 WHERE entry=34776; -- Siege Engine
UPDATE creature_template SET baseattacktime=2000,unit_flags=unit_flags|16384,unit_class=4 WHERE entry=34793; -- Catapult
UPDATE creature_template SET baseattacktime=2000,npcflag=npcflag|16777216,unit_flags=unit_flags|33570816,unit_class=4,speed_walk=1.2,VehicleId=436 WHERE entry=36355; -- Siege Turret
UPDATE creature_template SET baseattacktime=2000,unit_flags=unit_flags|16640,unit_class=4 WHERE entry=35069; -- Siege Engine

-- Model data 29489 (creature 34935 (Horde Gunship Cannon))
UPDATE creature_model_info SET bounding_radius=1.9,combat_reach=0,gender=2 WHERE modelid=29489; -- Horde Gunship Cannon
UPDATE creature_model_info SET bounding_radius=1,combat_reach=7.7,gender=2 WHERE modelid=25292; -- Siege Engine
UPDATE creature_model_info SET bounding_radius=0.305,combat_reach=5,gender=2 WHERE modelid=28106; -- Siege Turret
UPDATE creature_model_info SET bounding_radius=1,combat_reach=7.7,gender=2 WHERE modelid=26403; -- Siege Engine
UPDATE creature_model_info SET bounding_radius=1,combat_reach=7.7,gender=2 WHERE modelid=25292; -- Siege Engine
UPDATE creature_model_info SET bounding_radius=0.381875,combat_reach=1.25,gender=2 WHERE modelid=29734; -- Glaive Thrower

-- Addon data for creature 34775 (Demolisher)
DELETE FROM creature_template_addon WHERE entry=34775;
INSERT INTO creature_template_addon (entry,mount,bytes1,bytes2,emote,auras) VALUES
(34775,0,0,257,0, NULL); -- Demolisher
(34935,0,0,1,0, NULL); -- Horde Gunship Cannon
(34776,0,0,1,0, NULL); -- Siege Engine
(34793,0,0,257,0, NULL); -- Catapult
(36355,0,0,257,0, NULL); -- Siege Turret
(35069,0,0,1,0, NULL); -- Siege Engine
(35273,0,0,257,0, NULL); -- Glaive Thrower

DELETE FROM npc_spellclick_spells WHERE npc_entry IN (35273,34775,34935,34793,36355,35069);
INSERT INTO npc_spellclick_spells (npc_entry,spell_id,quest_start,quest_start_active,quest_end,cast_flags,aura_required,aura_forbidden,user_type) VALUES
(35273,68503,0,0,0,1,0,0,0), -- Glaive Thrower - Isle of Conquest
(34775,66245,0,0,0,1,0,0,0), -- Demolisher - Isle of Conquest
(34935,43671,0,0,0,1,0,0,0), -- Horde Gunship Cannon - Isle of Conquest
(34793,66245,0,0,0,1,0,0,0), -- Catapult - Isle of Conquest
(36355,46598,0,0,0,1,0,0,0), -- Siege Turret - Isle of Conquest
(35069,46598,0,0,0,1,0,0,0), -- Siege Engine - Isle of Conquest
[/sql]
8 
UPDATE `creature_template` SET `speed_walk`=0, `speed_run`=0 WHERE `entry`=34944; -- Keep Cannon

This is incorrect.

9

What is correct then ? This is partial fix because they shouldn’t have walk and run speed.

10

Nay, that query is really bad, It doesn’t work and I’m not sure what it does.

It updates the Creature_addon table for all the horde vehicles giving them emote’s that I’m not sure exists and changes their model info, that doesn’t really change anything. I will redo my old fix correctly and post it here.

11

I suppose Nay’s fixes are from sniffs. That’s why. /emoticons/default_wink.png

12

The cannon should cast a spell on player when entering vehicle that prevents movement.

13

Yes, it is sniffed and I am not setting emotes anywhere. The SQL I posted has some sql errors but that is not the point

It’s not complete, I lack some vehicle updates

14

My old sql worked, It only missed data for horde siege engine.

something that works < Sniffs

Only thing’s you need is data for Ally vehicles, my sql’s are of no use anymore.

15

Sniffs ALWAYS go above ANY other kind of information mate. You can’t deny that.

16

Problem is, sniffs are what made it to the client and tell us nothing about how they arrived at that number… take the health numbers for example, for a long time, everyone just plugged in the numbers that came from sniff or wdb, and didn’t bother to worry about how that number was calculated by the server, before being sent to the client, when we (I say we, because I was very instrumental in getting this done, even if no one will admit it) figured out how the health_mod, etc. worked, and came up with a table of base values to be calculated against certain other numbers, we could finally have correct health, even if something changed, without having to necessarily sniff out every creature again… the same could be pertinent here.

17

Agreed, sniffs are important but we know that sometimes they are not always completely correct, for whatever reason.

Its been a long time since I agreed with Paradox but this time I do. I have found things that absolutely do not work and were

done using sniffs. But going back to an older database found it was different, also with sniffs. So they can be misleading at times.

And then Blizz does like to just mess with our minds too.