Notice any Errors in this code ?

TrinityCore Development TrinityCore Code Discussion
1 

   bool bInCombat = isInCombat() && (!getVictim() ||                                        // if isInCombat() is true and this has no victim

                             !getVictim()->GetCharmerOrOwnerPlayerOrPlayerItself() ||                // or the victim/owner/charmer is not a player

                             !getVictim()->GetCharmerOrOwnerPlayerOrPlayerItself()->isGameMaster()); // or the victim/owner/charmer is not a GameMaster


            /*if (m_regenTimer <= diff)

            {*/

            if (!IsInEvadeMode() && (!bInCombat || IsPolymorphed())) // regenerate health if not in combat or if polymorphed

                RegenerateHealth();

bool incombat = if creature in combat and if creature has no victim and if has no owner or gamemaster

?

code doesnt look right to me

2

replaced this bit of code with this


 if (!IsInEvadeMode() && (!isInCombat() || IsPolymorphed()) && (!getVictim() || !getVictim()->GetCharmerOrOwnerPlayerOrPlayerItself() || !getVictim()->GetCharmerOrOwnerPlayerOrPlayerItself()->isGameMaster())) // regenerate health if not in combat or if polymorphed

                RegenerateHealth();