[Patch] NPC Bots

Paradox · January 2, 2014, 9:21pm

You probably need to do a clean and build, or, a full rebuild (same thing, really)

Ajaxhore · January 12, 2014, 2:18pm

Att. Trickerer.

How are things going with NPC Bots for current rev.?

Is there anything i/we can do to help out?

Reeeaalllyyy looking forward to having this back /emoticons/default_smile.png

trickerer · January 13, 2014, 3:07am

You want an update so bad? Okay, I’ll do it

Ajaxhore · January 13, 2014, 7:13am

trickerer

You just made my day, no. My week!

Thank you so much /emoticons/default_smile.png /emoticons/default_smile.png

Appreciated!

3t0n · January 13, 2014, 10:30am

nothing new? /emoticons/default_unsure.png

Ajaxhore · January 13, 2014, 1:40pm

Sadly not working right.

If i clone newest trinitycore master, i can apply patch.patch + ahbot.patch + telenpc2.patch without errors. And when i then try to apply NPC bots patch after those, it makes errors and wont apply.

And if i try it the other way around with a fresh trinitycore master clone, then i can apply NPC bots patch fine, but then patch.patch gives errors and wont apply.

For some reason the patches conflict so i can only either have NPC bots working or ahbot + telenpc2 working.

Dunno if that made any sence :-p

Proton · January 13, 2014, 9:33pm

Does the bots have global cooldown on their abilitys, i guess not? Here is what happend, i created lev 80 mage bot, i gave him full bis gear, then did a dps testing on a training dummy, my dps was like 12k but the magebot had like 71k dps , i watched him casting firebolt almost instantly and wihout globalcooldown, its like hes cheating lol, don’t know if this is your code or maybe bis equip make the bots to op.

trickerer · January 14, 2014, 1:21am

I didn’t test bots after last update, can’t say anything about dps but issue 83.

Bots do have global cooldown, but:

it scales with haste
in some cases bots can ignore it (fully or partially)

Sorry but making bots patch compatible with every other patch is not part of my job.

Apply rejected hunks manually, what else I can say

Sycoruler · January 14, 2014, 7:44pm

Your bots are awesome, sir

Oroduin · January 18, 2014, 4:51pm

i got this on osx with gcc 4.7.3:

http://pastebin.com/d62Ljwr9

trickerer · January 19, 2014, 3:33am

Seems like you need “WorldSession.h” include in your bot_shaman_ai.cpp file. Try to add it

Oroduin · January 19, 2014, 10:06am

Ok thats fixed, but now:

http://pastebin.com/NNvttsrZ

trickerer · January 19, 2014, 1:09pm

Same error with StatSystem.cpp, you know what to do. But please, next time you get compile errors create an issue instead of asking here

Paradox · January 19, 2014, 6:54pm

Only if you get those errors on a clean compile with no patches added, otherwise, he did exactly the right thing.

Aokromes · January 19, 2014, 8:45pm

Paradox trickerer means on bitbucket tracker for npcbots.

Paradox · January 20, 2014, 4:09am

Ahh, my mistake. Carry on. /emoticons/default_smile.png

Agency · February 18, 2014, 12:49pm

Dunno wat i’m doing wrong but i implemented the patch file and all SQL files to the proper databases, but when i enter ingame the commands do not work.

I’ve checked all C++ files for missing lines but nothing is missing. Any suggestions?

SyozZ · February 18, 2014, 12:58pm

[COLOR=rgb(40,40,40)]TrinityCore rev. b7509b5254ee 2014-02-14

[COLOR=rgb(40,40,40)]it works with that core atm. im testing with the newest core, if u dont mind /emoticons/default_tongue.png

[COLOR=rgb(40,40,40)]EDIT: TESTED With rev from 2014-02-18http://s1.directupload.net/images/140218/matofnr2.png

[COLOR=rgb(40,40,40)]seems not to work…

Kaless · February 27, 2014, 10:41pm

Thank you trickerer. This is something I’ve hoped for for quite some time.

trickerer · March 17, 2014, 7:25am

NPCBots when set to 4 do not work correctly and they regenerate mana at an unrealistic rate. I watched a priest bot fight 2 60 Elite Mobs and the priest would just replenish it’s mana over and over again. The mobs could never kill it because it would just replenish it’s mana and heal itself while casting all it’s spells over and over again. The spell rotation was correct but the bot could never run out of mana. I have also noted that with 4 bots the damage seems to be broken. I can fight a boss and the tank barely takes any damage and is never in any danger of dying. All boss fights with NPC Bots are underwhelming and not very fun. Once the joy of having NPC bots on you server wears off you realize that they are game breaking. I’m hoping that there will be some kind of fix with the bots because this is really one of the best addons I have used on my test server. I have noticed that with only 2 bots they seem to work correctly. I have had to set the bots per person down to 1 for now until this gets fixed because it’s just to easy. I have tried to set the bots damage modifiers down to help the problem and it works as intended but the bots are still doing the same thing as noted above.

Makes me proud of myself. Still, there is no need to post it everywhere since I’ve seen your issues on bitbucket already